fix!: Rename package to match name inferred from git URL #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
suggested changes
Nov 7, 2022
| @@ -55,7 +55,7 @@ fun writePackageManifest(settings: SwiftSettings, fileManifest: FileManifest, de | |||
| writer.write("name: \"${settings.moduleName}Tests\",") | |||
| writer.openBlock("dependencies: [", "],") { | |||
| writer.write("\$S,", settings.moduleName) | |||
| writer.write(".product(name: \"SmithyTestUtil\", package: \"ClientRuntime\")") | |||
There was a problem hiding this comment.
I tried to open /Users/jangirg/Projects/Amplify/SwiftSDK/aws-sdk-swift/codegen/sdk-codegen/build/smithyprojections/sdk-codegen/accessanalyzer.2019-11-01/swift-codegen and it failed to resolve
❯ swift package resolve
error: 'swift-codegen': unknown package 'AWSClientRuntime' in dependencies of target 'AWSAccessAnalyzer'; valid packages are: 'smithy-swift', 'aws-sdk-swift'
There was a problem hiding this comment.
Few things must be verified
- Individual package build located at /Users/jangirg/Projects/Amplify/SwiftSDK/aws-sdk-swift/codegen/sdk-codegen/build/smithyprojections/sdk-codegen/{service}/swift-codegen
- when packages are staged in
release - opening aws-crt-swift in xcode
- opening smityh-swift in xcode
- opening aws-sdk-swift in xcode without staged changes
- opening aws-sdk-swift in xcode with staged changes
There was a problem hiding this comment.
The broken Package.swift above is fixed in awslabs/aws-sdk-swift@f290fd4
There was a problem hiding this comment.
@ganeshnj All the situations you described have been tested out. I generated a release then built out all services as well.
There was a problem hiding this comment.
Thanks for testing. This is painful but needed until we have a better CI checks for such cases.
…into jbe/package_rename
…into jbe/package_rename
ganeshnj
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Fixes awslabs/aws-sdk-swift#680
Description of changes
Change the declared name of this package to match its inferred name (i.e. the last path component of its Git URL, minus the extension). This is being performed in conjunction with similar renames of
aws-sdk-swiftandsmithy-swift. A complete rationale for making this change is given in this PR.This is a breaking change but consumers of this package simply need to update their
Package.swiftto refer to the package by the new name.Specific changes:
ClientRuntimetosmithy-swiftScope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.