No-ops instead of encoding empty string when encoding an empty body in xml #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epau
force-pushed
the
epau/fix/xml-encoding-bandaid-2
branch
from
f5eb55b to
5f6596f
Compare
jbelkins
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
awslabs/aws-sdk-swift#580
Description of changes
This PR removes the logic that encodes an empty string for an empty body in xml.
Encoding an empty string, results in a "invalid list" error in CRT. (unknown if that is expected or not)
Regardless, doing nothing (or encoding nil) is preferable and more accurate as the expected payload should be empty.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.