feat: Adds IntEnum support #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate IntEnum shapes - Moves shared enum casing logic to Utils so it can be easily shared - Updates test generator to sort members by lower camel case
epau
commented
Nov 23, 2022
Comment on lines
-230
to
-243
| var enumCaseName = CaseUtils.toCamelCase( | ||
| name.orElseGet { | ||
| value | ||
| }.replace(Regex("[^a-zA-Z0-9_ ]"), "") | ||
| ) | ||
| if (!SymbolVisitor.isValidSwiftIdentifier(enumCaseName)) { | ||
| enumCaseName = "_$enumCaseName" | ||
| } | ||
|
|
||
| if (shouldBeEscaped && reservedWords.contains(enumCaseName)) { | ||
| enumCaseName = SymbolVisitor.escapeReservedWords(enumCaseName) | ||
| } | ||
|
|
||
| return enumCaseName |
There was a problem hiding this comment.
epau
commented
Nov 23, 2022
| import software.amazon.smithy.swift.codegen.model.nestedNamespaceType | ||
| import java.util.* | ||
|
|
||
| class IntEnumGenerator( |
There was a problem hiding this comment.
The contents of this file are mostly taken from the existing EnumGenerator with slight tweaks to support IntEnums specifically.
jbelkins
approved these changes
Nov 28, 2022
yep! will do that next! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.