fix: Remove backticks from reserved words before adding an identifier suffix #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
awslabs/aws-sdk-swift#1047
Description of changes
The newly-added
AWSVerifiedPermissions
service includes a structure with a property namedset
. Sinceset
is a Swift reserved word, our symbol generator wraps the name in backticks for use in generated Swift code.In the section that creates encoders/decoder methods, our code-generation tries to name a local variable by simply appending
Container
to the property name. If the backticks aren't removed before appending, this causes a compile error because`set`Container
is not a valid Swift identifier.To remedy, the places where an identifier is created from a property name have been modified to remove surrounding backticks first.
(also: Update dokka to 1.4.30, previous version 1.4.20 does not seem to resolve)
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.