feat: Make RetryStrategyOptions initializer public #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
reviewed
Jul 24, 2023
Comment on lines
+19
to
+21
| public init() { | ||
| self.init(options: ExponentialBackoffStrategyOptions()) | ||
| } |
There was a problem hiding this comment.
Why not keep the optional options as paramter?
There was a problem hiding this comment.
ExponentialBackoffStrategyOptions is not (yet) public. Not much point in making it public right now since there's no other backoff strategy available and we'd prefer that customers use our settings.
We may revisit this in the future.
waahm7
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Provide a public initializer for
RetryStrategyOptionsso that the AWS SDK may customize retry parameters.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.