fix: Add default value handling for a scalar member of server response struct #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
changed the title
This resolves the S3:deleteObjects() issue awslabs/aws-sdk-swift#602, as well as anytime there're scalar members with default values missing from server response. Issue is resolved by properly assigning the default value ("false") to deleteMarker property of DeletedObject when it is not found in server response (not found when bucket that responds to request is non-versioned, which means it does not use a deleteMarker).
sichanyoo
force-pushed
the
fix/S3-default-val
branch
from
4d6c146
to
1e57e58
Compare
sichanyoo
force-pushed
the
fix/S3-default-val
branch
from
651bbd2
to
2b36d8b
Compare
added 4 commits
August 9, 2023 11:39
…trait, not default value of the data type (0 / false).
…types are correctly translated.
dayaffe
requested changes
Aug 10, 2023
.../software/amazon/smithy/swift/codegen/integration/serde/xml/MemberShapeDecodeXMLGenerator.kt
Outdated
Show resolved
Hide resolved
jbelkins
requested changes
Aug 10, 2023
.../software/amazon/smithy/swift/codegen/integration/serde/xml/MemberShapeDecodeXMLGenerator.kt
Outdated
Show resolved
Hide resolved
jbelkins
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the deserialization error where a default value is not correctly assigned to fields when they're missing from server response.
Issue #
awslabs/aws-sdk-swift#602
Description of changes
Issue #602 is resolved by properly assigning the default value (
falsein this case) to deleteMarker property (a boolean member) of DeletedObject when it is not found in S3 server response due to the responding bucket not being versioned.With this change, when the deserializer tries to decode server response to S3:deleteObjects from a non-versioned S3 bucket, in each DeletedObject, default value is correctly assigned to be
falseto delete markers.Same applies for any other scalar member in any other server response structure that has a default value, if that member is missing from the server response struct.
A test case is added along with the change, as the change did not break any existing tests.
All changes were tested by building the
smithy-swiftproject, as well as generating all the services using the changed code generator and runningswift testas well as protocol tests on theaws-sdk-swiftproject.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.