fix: Add toBuilder() to SdkHttpRequest to easily allow customizations #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
requested changes
Sep 18, 2023
jbelkins
approved these changes
Sep 20, 2023
dayaffe
requested changes
Sep 20, 2023
added 3 commits
September 20, 2023 14:22
…om:awslabs/smithy-swift into fix/add-tobuilder-method-to-sdkhttprequest
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#583
Description of changes
Adds a convenience method
toBuilder()toSdkHttpRequestto allow customers to easily obtain a builder object that has all the fields fromSdkHttpRequest. This will allow customers to update / customize any fields in the builder, then callbuild()on the builder to obtain a mutatedSdkHttpRequestobject they want.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.