Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support Swift 5.x versions past 5.9 in metadata #589

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jbelkins
Copy link
Contributor

Issue #

awslabs/aws-sdk-swift#1135

Description of changes

Swift 5.9 was just released with Xcode 15. The Swift core team has indicated that the release of Swift 6 is not imminent, so further Swift 5 minor releases are expected.

This PR extends the Swift metadata generation to handle Swift 5 minor versions up to Swift 5.19.

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbelkins jbelkins merged commit 9ff72f2 into main Sep 19, 2023
7 checks passed
@jbelkins jbelkins deleted the jbe/moar_swift_versions branch September 19, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants