feat: add stored property for adding additional headers in SdkHttpRequest #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the ability to add additional headers to an existing request of type SdkHttpRequest.
Issue #
#1130
#583
Description of changes
Cause:
headers
is already a mutable property but it is computed without any stored values. This means that a customer who attempts to modify headers will either have no effect (because computed properties are read-only) or because it points to an instance ofendpoint.headers
whose headers are immutable.Solution: Add
additionalHeaders
stored property which is mutable and provide add/removal methods.Risk: Computed properties ensure that the request is never modified in-transit. In order to reduce any risk associated I have chosen to add a new property that is mutable, stores values, and provided my own setters rather than modify the existing property to no longer be computed. Additionally, we should remove this functionality once Swift SDK SRA-compliant with interceptors (#307)
How to use:
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.