feat: add retry and http client plugins #671
Conversation
| config.retryStrategyOptions = | ||
| DefaultSDKRuntimeConfiguration<DefaultRetryStrategy, DefaultRetryErrorInfoProvider> | ||
| .defaultRetryStrategyOptions | ||
| } | ||
|
|
||
| if var config = clientConfiguration as? DefaultHttpClientConfiguration { | ||
| var httpClientConfiguration = DefaultSDKRuntimeConfiguration<DefaultRetryStrategy, DefaultRetryErrorInfoProvider> |
There was a problem hiding this comment.
As I understand it, DefaultSDKRuntimeConfiguration (which is one of the old config structs) has not been refactored (e.g., refactor to conform to the new ClientConfiguration protocol, or delete and replace with the new SRA config) yet. Will the DefaultSDKRuntimeConfiguration struct used here be refactored down the line?
There was a problem hiding this comment.
Will the DefaultSDKRuntimeConfiguration struct used here be refactored down the line?
Yes. I will try to send out a PR later this week. I have refactored and included the changes in this PR.
| @@ -81,19 +82,13 @@ open class HttpProtocolServiceClient( | |||
| writer.openBlock("return ClientBuilder<\$L>(defaultPlugins: [", "])", serviceSymbol.name) { | |||
|
|
|||
| val defaultPlugins: MutableList<Plugin> = mutableListOf(DefaultClientPlugin()) | |||
| val customPlugins: MutableList<Plugin> = mutableListOf() | |||
There was a problem hiding this comment.
Q: What fell under customPlugins, and why is the codegen for it deleted now?
There was a problem hiding this comment.
There weren't any plugins that fell under custom plugins. It should only be default plugins.
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
2 times, most recently
from
555e17c to
d1adea7
Compare
| writer.write("let config = try \$L(\"\$L\", \"\$L\")", serviceConfig.typeName, serviceName, serviceSymbol.name) | ||
| writer.write("let config = try \$L()", serviceConfig.typeName) |
There was a problem hiding this comment.
Nice change 👍 . Are these set anywhere else right now?
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
d1adea7 to
29d1bae
Compare
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
29d1bae to
d553ad3
Compare
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.