-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Observability Runtime Interfaces #674
Conversation
b471f15
to
15a9a77
Compare
da3bb45
to
ce022cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additions look great, but given that these protocols are going to be semi-permanent & end-users are expected to implement them for customizations, I think the public protocols and methods in them need documentation comments. E.g.,
/// Brief overview on method usage.
///
/// - Parameter: input : Comment
/// - Returns: ReturnABC : Comment
func fillerFunc(input: ParamABC) -> ReturnABC
f2ac676
to
57ba71c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly questions and some small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few superficial changes to make. I will put these in & merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I entered some cleanup changes myself. This change is now good to merge, per conversation with @syall.
Issue #
awslabs/aws-sdk-swift#696
Description of changes
Standardizes the Observability client runtime configuration and interfaces:
Also, adds the default implementation of
TelemetryProvider
.This PR is only additive besides the moved
Logging
source files.Testing
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.