Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove reference to KinesisClientTypes.Tag and set variable directly #684

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: remove reference to KinesisClientTypes.Tag and set variable directly #684

merged 1 commit into from
Mar 19, 2024

Conversation

dayaffe
Copy link
Contributor

@dayaffe dayaffe commented Mar 18, 2024 •
edited
Loading

Issue #

Description of changes

  • KinesisClientTypes.Tag should not be referenced in generic code-gen
  • Tag is unnecessary we can just get set the variable directly

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins self-requested a review March 19, 2024 15:32
@dayaffe dayaffe merged commit 90d3df4 into main Mar 19, 2024
12 checks passed
@dayaffe dayaffe deleted the day/remove-kinesis-client-type-ref branch March 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbelkins jbelkins jbelkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dayaffe @jbelkins