Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove client properties feature #726

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

jbelkins
Copy link
Contributor

Description of changes

The ClientProperty type is removed since it is no longer used, and client generators no longer maintain a set of client properties. (ClientProperty was previously used to configure encoders & decoders, which are no longer used.)

Also: some unrelated dead code was removed.

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jbelkins jbelkins merged commit a0b43f0 into main May 15, 2024
17 checks passed
@jbelkins jbelkins deleted the jbe/remove_client_properties branch May 15, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants