feat: Add OS version info to user agent for Linux & Windows #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
requested changes
May 24, 2024
Comment on lines
17
to
31
| #elseif os(Linux) | ||
| import Glibc | ||
| public struct PlatformOperationSystemVersion { | ||
| static public func operatingSystemVersion() -> String? { | ||
| var sysInfo = utsname() | ||
| uname(&sysInfo) | ||
| var local = sysInfo | ||
| let releaseVersion = withUnsafePointer(to: &local.release) { | ||
| $0.withMemoryRebound(to: CChar.self, capacity: MemoryLayout.size(ofValue: sysInfo.release)) { | ||
| String(cString: $0) | ||
| } | ||
| } | ||
| return releaseVersion | ||
| } | ||
| } |
There was a problem hiding this comment.
swift-foundations provides ProcessInfo have you tried that out? It looks like it has a linux implementation and perhaps even a windows implementation for obtaining operatingSystemVersion. I think we can use that directly
| } | ||
| return releaseVersion | ||
| } | ||
| } | ||
| #else | ||
| // TODO: Implement for Linux & Windows |
sichanyoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
awslabs/aws-sdk-swift#1206
Description of changes
Delete no-longer-necessary compiler directives.
Apple recently implemented getting OS versions for Linux & Windows for us in
Foundation.ProcessInfo.Tested on Linux via cloud desktop running Amazon Linux 2.
Example
User-Agentheader value from test run:Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.