Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SwiftWriter imports types that are written to code #745

Merged
merged 1 commit into from
May 30, 2024

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented May 30, 2024

Issue #

awslabs/aws-sdk-swift#1533

Description of changes

  • SwiftWriter will now automatically import any symbol that is written to code using the $N, $D, or $T format specifier.
  • Swift symbols may now have their declaration type added to them; if they do, then only that type is imported. If not, the entire enclosing module is imported instead.
  • ClientRuntime.Core Swift symbols have their Swift declaration type added so they may be imported. Other symbols will be modified in future PRs (and existing SwiftWriter.import() calls deleted) in future PRs.

also:

  • WeatherSDK updated with new imports

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins merged commit 999add0 into main May 30, 2024
17 checks passed
@jbelkins jbelkins deleted the jbe/swift_writer_auto_import branch May 30, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants