Skip to content

Commit

Permalink
chore(codegen): match lib and target declarations (#678)
Browse files Browse the repository at this point in the history
`lib` declarations targeting standards newer than the `target` are
useful when one polyfills missing features.

`lib` declarations targeting _older_ standards are constraining in a
strange way: we emit code relying on newer features, but types prevent
us from using them

Since were are already emitting `es2018` code, we can target that
standard for the types as well.

This is a spin-off of @eduardomourar's #667

Co-authored-by: Eduardo Rodrigues <eduardomourar@users.noreply.github.com>
  • Loading branch information
aisamu and eduardomourar authored Feb 3, 2023
1 parent fb70a7b commit 366c0fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion smithy-typescript-ssdk-libs/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"module": "commonjs",
"moduleResolution": "node",
"target": "ES2018",
"lib": ["es2015", "dom"],
"lib": ["es2018", "dom"],
"baseUrl": ".",
"strict": true,
"declaration": true,
Expand Down

0 comments on commit 366c0fd

Please sign in to comment.