Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LinkedHashMap to preserve order #108

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 23, 2020

Use LinkedHashMap to preserve existing order when generating models

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Contributor

trivikr commented Jan 23, 2020

TreeMap reordered enums and interfaces as shown in the first commit in aws/aws-sdk-js-v3#782

@srchase srchase merged commit 52efea0 into smithy-lang:master Jan 23, 2020
@srchase srchase deleted the preserve-model-order branch January 23, 2020 23:45
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Jan 23, 2020
@trivikr
Copy link
Contributor

trivikr commented Jan 23, 2020

Verified that the code changes introduced by using TreeMap in #105 were undone by this PR

Commit: aws/aws-sdk-js-v3@c80165f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants