Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): match lib and target declarations #678

Merged

Commits on Jan 26, 2023

  1. chore(codegen): match lib and target declarations

    `lib` declarations targeting standards newer than the `target` are
    useful when one polyfills missing features.
    
    `lib` declarations targeting _older_ standards are constraining in a
    strange way: we emit code relying on newer features, but types prevent
    us from using them
    
    Since were are already emitting `es2018` code, we can target that
    standard for the types as well.
    
    This is a spin-off of @eduardomourar's smithy-lang#667
    
    Co-authored-by: Eduardo Rodrigues <eduardomourar@users.noreply.github.com>
    aisamu and eduardomourar committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    71a205a View commit details
    Browse the repository at this point in the history