Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to check optional Client Configuration #858

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Aug 7, 2023

Issue #, if available:
Refs: aws/aws-sdk-js-v3#3415

Description of changes:

Adds type to check optional Client Configuration.

Testing done in generated code in aws/aws-sdk-js-v3#5060


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review August 7, 2023 20:54
@trivikr trivikr requested review from a team as code owners August 7, 2023 20:54
packages/types/src/client.ts Outdated Show resolved Hide resolved
@trivikr trivikr merged commit 59548ba into smithy-lang:main Aug 7, 2023
@trivikr trivikr deleted the type-check-optional-config branch August 7, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants