You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Snapshot dependency resolution is broken if multiple repositories with the same hostname are defined in smithy-build.json.
The underlying aether resolution relies on the repository definition to have a discriminator id for de-duplicating repositories.
The current smithy build definition doesn't have that, thus resolution fails.
Steps to reproduce
Consider the following smithy definition:
{
"version": "1.0",
"maven": {
"repositories": [
{
"url": "http://localhost:1234/artifactory-1"
},
{
"url": "http://localhost:1234/artifactory-2"
}
],
"dependencies": [
// Normally, this could refer to SMITHY_VERSION, but that doesn't work for pre-release builds.
"com.example:artifact:1.0.0-SNAPSHOT"
]
}
}
and the following pom file definition for com.example:artifact:1.0.0-SNAPSHOT:
Snapshot dependency resolution is broken if multiple repositories with the same hostname are defined in
smithy-build.json
.The underlying aether resolution relies on the repository definition to have a discriminator id for de-duplicating repositories.
The current smithy build definition doesn't have that, thus resolution fails.
Steps to reproduce
Consider the following smithy definition:
and the following pom file definition for
com.example:artifact:1.0.0-SNAPSHOT
:After configuring
http://localhost:1234/artifactory-1
to host the release version ofcom.example:dependency:1.0.0
http://localhost:1234/artifactory-2
to host the snapshot version ofcom.example:artifact:1.0.0-SNAPSHOT
We would expect the dependency resolution to succeed, but instead it fails.
Fixed by #1884 and 6e68005 adds a test to exemplify the behavior.
The text was updated successfully, but these errors were encountered: