Fix snapshot dependency resolution #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvschneid
suggested changes
Jul 26, 2023
smithy-build/src/main/java/software/amazon/smithy/build/model/MavenRepository.java
Outdated
Show resolved
Hide resolved
smithy-build/src/main/java/software/amazon/smithy/build/model/MavenRepository.java
Outdated
Show resolved
Hide resolved
smithy-build/src/main/java/software/amazon/smithy/build/model/MavenRepository.java
Outdated
Show resolved
Hide resolved
smithy-cli/src/it/java/software/amazon/smithy/cli/MavenResolverMultipleReposTest.java
Outdated
Show resolved
Hide resolved
kubukoz
reviewed
Jul 26, 2023
| @@ -96,11 +96,11 @@ public void serviceCreationFailed(Class<?> type, Class<?> impl, Throwable except | |||
| public void addRepository(MavenRepository repository) { | |||
| try { | |||
| URI uri = new URI(repository.getUrl()); | |||
| String name = uri.getHost(); | |||
| String id = repository.getId().orElseGet(() -> uri.getHost()); | |||
There was a problem hiding this comment.
suggestion: now that I think of it, perhaps we could default to the index instead (in the list of available repos)? That way it's still going to be unique.
There was a problem hiding this comment.
That should work. Maybe something like index + "|" + uri.getHost() for better logs/debugging? Something like "|" can't be used in host, so shouldn't be ambiguous in any scenario.
There was a problem hiding this comment.
Done.
Index starts at 1, let me know if you want to bikeshed 😄
mtdowling
requested changes
Jul 26, 2023
smithy-build/src/main/java/software/amazon/smithy/build/model/MavenRepository.java
Outdated
Show resolved
Hide resolved
denisrosca
force-pushed
the
hostname-multiple-resolvers
branch
from
dd0df29
to
2f48eee
Compare
denisrosca
force-pushed
the
hostname-multiple-resolvers
branch
from
2a8d9de
to
3b175ae
Compare
jvschneid
approved these changes
Jul 27, 2023
mtdowling
approved these changes
Jul 27, 2023
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Closes #1883 *
Description of changes:
Add an optional id for the maven repository definition.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.