Support enum map keys on OpenAPI 3.1.0 #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
commented
Aug 2, 2023
| @@ -67,23 +66,6 @@ public void convertsModels() { | |||
| assertTrue(document.toNode().expectObjectNode().getMember("components").isPresent()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void stripsUnsupportedKeywords() { | |||
There was a problem hiding this comment.
This behavior is now covered by the convertsToOpenAPI3_0_2 and convertsToOpenAPI3_1_0 tests in OpenApiConverterTest.
sugmanue
approved these changes
Aug 2, 2023
mtdowling
reviewed
Aug 10, 2023
| @@ -46,6 +53,11 @@ public boolean supportsContentEncodingKeyword() { | |||
| return supportsContentEncodingKeyword; | |||
| } | |||
|
|
|||
| @SmithyInternalApi | |||
| public Set<String> getUnsupportedKeywords() { | |||
There was a problem hiding this comment.
Oh interesting to make this version specific. Is this internal because you aren't sure about the design? Maybe unstable instead if that's the concern?
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1664
This PR updates OpenAPI configuration to allow
propertyNamesto be set when using version3.1.0.Previously,
propertyNameswas stripped from outputs as an unsupported keyword, since OpenAPI 3.0 did not support it.By allowing
propertyNames, enums can be used as map keys, without discarding all of the enum information.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.