Add ServiceIndex method to account for smithy.api#noAuth #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
commented
Aug 15, 2023
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/knowledge/ServiceIndexTest.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Aug 15, 2023
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
syall
suggested changes
Aug 15, 2023
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
gosar
force-pushed
the
noAuth-scheme
branch
5 times, most recently
from
5cb8e80
to
f96464f
Compare
syall
approved these changes
Aug 16, 2023
Use AuthSchemeMode enum
mtdowling
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
getNoAuthAwareEffectiveAuthSchemesmethod to ServiceIndex that wrapsgetEffectiveAuthSchemesto account forsmithy.api#noAuthscheme.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.