Improve NumberNode #1965
Merged
Improve NumberNode #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
improve-number-node
branch
from
3f6039d
to
12f63bf
Compare
mtdowling
changed the title
This change now makes the BigDecimal get created eagerly, and accounts for NaN and Infinity. The previous implementation would have failed in these cases. NodeValidationVisitor now uses the computed BigDecimal rather than create a one-off each time. It also doesn't recreate the already available BigDecimcal of the range trait. This change deprecates isNaturalNumber since that method was poorly named. A natural number is an integer >= 1, but we were including 0 (which is likely why some callers assumed it asserts >= 0). This also adds an isNegative method since multiple callers need to assert that a NumberNode contains a non-negative value.
mtdowling
force-pushed
the
improve-number-node
branch
from
12f63bf
to
3044d8a
Compare
kstich
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change now makes the BigDecimal get created eagerly, and accounts
for NaN and Infinity. The previous implementation would have failed
in these cases. NodeValidationVisitor now uses the computed BigDecimal
rather than create a one-off each time. It also doesn't recreate the
already available BigDecimcal of the range trait.
This change deprecates isNaturalNumber since that method was poorly
named. A natural number is an integer >= 1, but we were including 0
(which is likely why some callers assumed it asserts >= 0).
This also adds an isNegative method since multiple callers need to
assert that a NumberNode contains a non-negative value.