Add declarative endpoints traits #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Sep 29, 2023
.../amazon/smithy/rulesengine/aws/language/functions/endpoints/DualStackOnlyEndpointsTrait.java
Outdated
Show resolved
Hide resolved
.../amazon/smithy/rulesengine/aws/language/functions/endpoints/DualStackOnlyEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/smithy/rulesengine/aws/language/functions/endpoints/EndpointModifierTrait.java
Outdated
Show resolved
Hide resolved
...software/amazon/smithy/rulesengine/aws/language/functions/endpoints/EndpointPatternType.java
Outdated
Show resolved
Hide resolved
...amazon/smithy/rulesengine/aws/language/functions/endpoints/PartitionEndpointSpecialCase.java
Outdated
Show resolved
Hide resolved
...a/software/amazon/smithy/rulesengine/aws/language/functions/endpoints/RegionSpecialCase.java
Outdated
Show resolved
Hide resolved
smithy-aws-endpoints/src/main/resources/META-INF/smithy/aws.endpoints.smithy
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...n/smithy/rulesengine/aws/language/functions/endpoints/StandardPartitionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
endpoint-traits
branch
4 times, most recently
from
2da1cb9 to
b56906f
Compare
kstich
requested changes
Oct 4, 2023
smithy-aws-endpoints/src/main/resources/META-INF/smithy/aws.endpoints.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-endpoints/src/main/resources/META-INF/smithy/aws.endpoints.smithy
Show resolved
Hide resolved
...n/smithy/rulesengine/aws/language/functions/endpoints/StandardPartitionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...n/smithy/rulesengine/aws/language/functions/endpoints/StandardPartitionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
|
Also un-resolved some previous comments that weren't fully taken care of. |
AndrewFossAWS
force-pushed
the
endpoint-traits
branch
3 times, most recently
from
b816f0c to
333e45c
Compare
kstich
requested changes
Oct 16, 2023
...points/src/main/resources/META-INF/services/software.amazon.smithy.model.traits.TraitService
Outdated
Show resolved
Hide resolved
.../amazon/smithy/rulesengine/aws/language/functions/endpoints/DualStackOnlyEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/smithy/rulesengine/aws/language/functions/endpoints/EndpointModifierTrait.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/smithy/rulesengine/aws/language/functions/endpoints/EndpointModifierIndex.java
Outdated
Show resolved
Hide resolved
...ware/amazon/smithy/rulesengine/aws/language/functions/endpoints/RuleBasedEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
...azon/smithy/rulesengine/aws/language/functions/endpoints/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
smithy-aws-endpoints/src/main/resources/META-INF/smithy/aws.endpoints.smithy
Show resolved
Hide resolved
...re/amazon/smithy/rulesengine/aws/language/functions/endpoints/EndpointModifierIndexTest.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Oct 16, 2023
...n/smithy/rulesengine/aws/language/functions/endpoints/StandardPartitionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
endpoint-traits
branch
from
333e45c to
81077d0
Compare
kstich
reviewed
Oct 18, 2023
...in/java/software/amazon/smithy/rulesengine/aws/traits/StandardPartitionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
.../main/java/software/amazon/smithy/rulesengine/aws/traits/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
.../main/java/software/amazon/smithy/rulesengine/aws/traits/StandardRegionalEndpointsTrait.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
endpoint-traits
branch
from
81077d0 to
2d28477
Compare
kstich
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add declarative endpoints traits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.