Add equals and hashCode to ErrorExample
#2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have this reviewed and released? Related: #2009 |
gosar
reviewed
Dec 4, 2023
smithy-model/src/main/java/software/amazon/smithy/model/traits/ExamplesTrait.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
gosar
approved these changes
Dec 5, 2023
Hi @miguel-vila, can you rebase? I can merge after that. Thanks. |
rchache
pushed a commit
to rchache/smithy
that referenced
this pull request
Jan 2, 2024
* Add `equals` and `hashCode` implementations to `Example` and `ExampleOrder` * remove line * add negative test * Use `Objects.equals` Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com> --------- Co-authored-by: Miguel Villa <miguel.villa@siriusxm.com> Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We looked into this because we were having some false negatives while comparing values of the
@examplestrait. Part of it was using an old version of smithy which didn't have anequalsforExample, but this could happen if the trait also has anErrorExample.Description of changes:
Adds a simple implementation and a test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.