Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parameterizedTestSource public #2087

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

JordonPhillips
Copy link
Contributor

This makes the parameterizedTestSource method of the test suite class public, allowing people to use a customized suite as a source for JUnit parameterized tests. Previously the only way to use the test suite as a parameterized test source was to use the default method that only lets you customize the class loader by passing in a class to source it from.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This makes the `parameterizedTestSource` method of the test suite
class public, allowing people to use a customized suite as a source
for JUnit parameterized tests. Previously the only way to use the
test suite as a parameterized test source was to use the default
method that only lets you customize the class loader by passing in
a class to source it from.
@JordonPhillips JordonPhillips requested a review from a team as a code owner December 28, 2023 14:42
@JordonPhillips JordonPhillips merged commit 3fa506a into smithy-lang:main Dec 29, 2023
10 checks passed
@JordonPhillips JordonPhillips deleted the public-test-suite branch December 29, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants