Add JSON protocol tests for document-valued maps #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Feb 6, 2024
| /// This example serializes documents as the value of maps. | ||
| @idempotent | ||
| @http(uri: "/DocumentTypeAsMapKey", method: "PUT") | ||
| operation DocumentTypeAsMapKey { |
There was a problem hiding this comment.
Document is the map value in these tests, all the names should be updated accordingly.
| apply DocumentTypeAsMapKey @httpResponseTests([ | ||
| { | ||
| id: "DocumentTypeAsMapKeyOutput", | ||
| documentation: "Deserializes a map that uses documents as the value.", |
There was a problem hiding this comment.
Suggested change
| documentation: "Deserializes a map that uses documents as the value.", | |
| documentation: "Serializes a map that uses documents as the value.", |
nit: Since this isn't client specific
…n' instead of 'deserialization' in documentation
kstich
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
This change adds tests for serializing/deserializing maps which use the document shape as a value. The AWS SDK for Kotlin previously did not handle these correctly, leading to a customer contact.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.