Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatter to correctly convert invalid doc comments #2277

Merged
merged 2 commits into from
May 8, 2024

Conversation

haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented May 7, 2024

Background

  • Fixes an issue where a doc-comment above a trait-statement and member may get converted to a line-comment
  • Updates the expected formatting of test case file (.formatted.smithy)
  • Updates tests to use assertEquals, since it provides diff functionality in IDEs

Testing

  • Ran the tests, no failures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@milesziemer milesziemer force-pushed the fix-doc-comment-conversion branch from 34ee27c to c039f6f Compare May 8, 2024 17:42
@milesziemer
Copy link
Contributor

I pushed a commit that fixes the regression, which is captured by what I added to the test case here. The TODO here is a separate issue that occurs when the comment is after a default value assignment. We will need to follow up to address that.

@milesziemer milesziemer marked this pull request as ready for review May 8, 2024 17:44
@milesziemer milesziemer requested a review from a team as a code owner May 8, 2024 17:44
@milesziemer milesziemer requested a review from hpmellema May 8, 2024 17:45
@haydenbaker haydenbaker requested review from kstich and removed request for hpmellema May 8, 2024 18:46
@milesziemer
Copy link
Contributor

Followup work: #2279

@milesziemer milesziemer merged commit e71e5c8 into main May 8, 2024
14 checks passed
@sugmanue sugmanue deleted the fix-doc-comment-conversion branch May 8, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants