Add required for service resolved condition keys #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `required` property to `@defineConditionKeys` to be used when a condition key MUST be resolved by the service. Request resolved keys MUST use the `@required` trait.
This commit refactors the validation for this property and fixes several bugs with it: It uses the ConditionKeyIndex, checks for keys defined within a single services, and checks all keys defined in the trait instead of just the first. Several other minor patches to the previous commit are also applied.
kstich
changed the title
milesziemer
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What do these changes do?
requiredproperty to the definitions provided in@aws.iam#defineConditionKeys.Why are they important?
Testing
Based on #2183
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.