Add protocol tests relating to Content-Type and @httpPayload
#2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial motivation for this stems off smithy-lang#2310, but for when the input is `@httpPayload`-bound. It's important that we test `Content-Type` specifically with `@httpPayload` operations, because the header can be checked without having to inspect the body, and because the spec has special provisions (https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type). There were no protocol tests exercising `Content-Type` when the input is `@httpPayload`-bound: - In the case of blobs, servers must accept any (test already exists) and no `Content-Type` (test added in this commit). - In other cases, there were protocol tests for `union` and `structure` shapes. I've added an operation with an `@httpPayload`-bound string shape. Note that `document` shapes remain untested.
As per the specs for these protocols, a `Content-Type` header should be set. Server should reject requests when an expected `Content-Type` header is not found (protcol tests for that are added in smithy-lang#2314). - https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type - https://smithy.io/2.0/aws/protocols/aws-restxml-protocol.html#content-type
david-perez
added a commit
to david-perez/smithy
that referenced
this pull request
Jun 11, 2024
As per the specs for these protocols, a `Content-Type` header should be set. Server should reject requests when an expected `Content-Type` header is not found (protcol tests for that are added in smithy-lang#2314). - https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type - https://smithy.io/2.0/aws/protocols/aws-restxml-protocol.html#content-type
JordonPhillips
requested changes
Jun 13, 2024
JordonPhillips
pushed a commit
that referenced
this pull request
Jun 13, 2024
As per the specs for these protocols, a `Content-Type` header should be set. Server should reject requests when an expected `Content-Type` header is not found (protcol tests for that are added in #2314). - https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type - https://smithy.io/2.0/aws/protocols/aws-restxml-protocol.html#content-type
JordonPhillips
approved these changes
Jun 17, 2024
david-perez
deleted the
davidpz/rest-json-with-bound-body-expects-application-json-content-type-no-headers
branch
david-perez
added a commit
to david-perez/smithy
that referenced
this pull request
Jun 18, 2024
In smithy-lang#2314, I added an operation featuring an `@httpPayload`-bound shape to test `Content-Type` header checking, among other things. However, I failed to notice there is already a `http-string-payload.smithy` file in the test suite to test `@httpPayload`-bound string shapes. This PR merges and applies the tests I added in smithy-lang#2314 to the operation that already existed.
JordonPhillips
pushed a commit
that referenced
this pull request
Jun 18, 2024
In #2314, I added an operation featuring an `@httpPayload`-bound shape to test `Content-Type` header checking, among other things. However, I failed to notice there is already a `http-string-payload.smithy` file in the test suite to test `@httpPayload`-bound string shapes. This PR merges and applies the tests I added in #2314 to the operation that already existed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protocol tests relating to
Content-Typeand@httpPayloadInitial motivation for this stems off #2310, but for when the input is
@httpPayload-bound. It's important that we testContent-Typespecifically with
@httpPayloadoperations, because the header can bechecked without having to inspect the body, and because the spec has
special provisions
(https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type).
There were no protocol tests exercising
Content-Typewhen the input is@httpPayload-bound:and no
Content-Type(test added in this commit).unionandstructureshapes. I've added an operation with an
@httpPayload-bound stringshape. Note that
documentshapes remain untested.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.