Add restJson1 protocol test for content-type and POST operation with no input #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
reviewed
Jul 1, 2024
| method: "POST", | ||
| uri: "/no_input_no_payload", | ||
| body: "", | ||
| forbidHeaders: [ | ||
| "Content-Type" |
There was a problem hiding this comment.
looks like missed Content-Length here
There was a problem hiding this comment.
Clients SHOULD include Content-Length: 0 on a POST without no body, hence not including Content-Length in forbidHeaders here: https://datatracker.ietf.org/doc/html/rfc7230#section-3.3.2
| apply TestNoInputNoPayload @httpRequestTests([ | ||
| @readonly | ||
| @http(uri: "/no_input_no_payload", method: "POST") | ||
| operation TestPostNoInputNoPayload { |
There was a problem hiding this comment.
I'd say add TestPostNoPayload (similar to TestNoPayload but with POST) also. That would actually more closely represent the issue represented in the .NET issue.
gosar
reviewed
Jul 12, 2024
smithy-aws-protocol-tests/model/restJson1/http-content-type.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-protocol-tests/model/restJson1/http-content-type.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-protocol-tests/model/restJson1/http-content-type.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-protocol-tests/model/restJson1/http-content-type.smithy
Outdated
Show resolved
Hide resolved
gosar
approved these changes
Jul 12, 2024
gosar
reviewed
Jul 12, 2024
smithy-aws-protocol-tests/model/restJson1/http-content-type.smithy
Outdated
Show resolved
Hide resolved
gosar
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.