Fix several bugs in AwsTagIndex #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested review from
haydenbaker,
a team,
gosar and
JordonPhillips
and removed request for
a team,
haydenbaker and
gosar
JordonPhillips
requested changes
Aug 28, 2024
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java
Outdated
Show resolved
Hide resolved
This commit fixes several groups of bugs in the AwsTagIndex: 1. The index did not handle nested resource shapes. 2. The index did not handle the put lifecycle operation. 3. The index did not account for the `apiConfig` property of the `@taggable` trait. A full suite of tests was added to account for the index's behavior and validate its previous functionality along with fixes for the above. The `getTagsMember` method was stabilized and made non-static. Minor cleanup was done to other tagging related files.
kstich
force-pushed
the
tagOnCreate_put_fix
branch
from
6a5c728 to
7c57964
Compare
JordonPhillips
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes several groups of bugs in the AwsTagIndex:
apiConfigproperty of the@taggabletrait.A full suite of tests was added to account for the index's behavior and validate its previous functionality along with fixes for the above.
The
getTagsMembermethod was stabilized and made non-static.Minor cleanup was done to other tagging related files.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.