Add delimiter and reusable to arn trait #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
commented
Nov 1, 2024
| @@ -151,11 +177,14 @@ public Builder toBuilder() { | |||
| .sourceLocation(getSourceLocation()) | |||
| .noRegion(isNoRegion()) | |||
| .noAccount(isNoAccount()) | |||
| .template(getTemplate()); | |||
| .absolute(isAbsolute()) | |||
There was a problem hiding this comment.
This is a bug fix as well - absolute wasn't maintained going to the builder.
hpmellema
reviewed
Nov 1, 2024
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ArnTrait.java
Show resolved
Hide resolved
This commit adds two fields to the aws.api#arn trait: * resourceDelimiter - used to define the delimiter for resource segments of absolute ARN templates. * reusable - indicates whether an ARN may be reused for different instances of a resource.
kstich
force-pushed
the
add_arn_trait_properties
branch
from
5ac578a to
3be41df
Compare
hpmellema
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two fields to the aws.api#arn trait:
Note: two test files were migrated to
.smithythat aren't changed otherwise. While unrelated, this is a net-positive so I've left it in.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.