Add transform to mark required idempotency tokens client optional #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpmellema
force-pushed
the
token-transform
branch
from
bc2be87 to
10afc97
Compare
hpmellema
force-pushed
the
token-transform
branch
from
10afc97 to
38cde40
Compare
yasmewad
approved these changes
Nov 15, 2024
This is not a concern for existing customers but opens up the ability to easily inject these tokens in newer code-generated clients. |
kstich
requested changes
Nov 15, 2024
...c/main/java/software/amazon/smithy/build/transforms/MakeIdempotencyTokensClientOptional.java
Outdated
Show resolved
Hide resolved
...codegen-core/src/main/java/software/amazon/smithy/codegen/core/directed/CodegenDirector.java
Outdated
Show resolved
Hide resolved
...codegen-core/src/main/java/software/amazon/smithy/codegen/core/directed/CodegenDirector.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/model/transform/MakeIdempotencyTokenClientOptional.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
…en/core/directed/CodegenDirector.java Co-authored-by: Kevin Stich <kevin@kstich.com>
…en/core/directed/CodegenDirector.java Co-authored-by: Kevin Stich <kevin@kstich.com>
Co-authored-by: Kevin Stich <kevin@kstich.com>
mtdowling
requested changes
Nov 15, 2024
...codegen-core/src/main/java/software/amazon/smithy/codegen/core/directed/CodegenDirector.java
Outdated
Show resolved
Hide resolved
…en/core/directed/CodegenDirector.java Co-authored-by: Michael Dowling <michael@mtdowling.com>
JordonPhillips
approved these changes
Nov 15, 2024
JordonPhillips
approved these changes
Nov 15, 2024
JordonPhillips
approved these changes
Nov 15, 2024
kstich
approved these changes
Nov 15, 2024
mtdowling
approved these changes
Nov 15, 2024
MYoung25
pushed a commit
to MYoung25/smithy
that referenced
this pull request
Nov 29, 2024
…ithy-lang#2466) Add transform to make required `@idempotencyToken` members `@clientOptional` so that they can be left empty and injected. --------- Co-authored-by: Kevin Stich <kevin@kstich.com> Co-authored-by: Michael Dowling <michael@mtdowling.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a transform that marks required Idempotency tokens
@clientOptional. This is important because it changes the nullability of idempotency tokens for code generators, allow customers to leave the field unset and have their client inject the value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.