Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opinionated protocol tests to not describe optional behavior #481

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Update opinionated protocol tests to not describe optional behavior #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0153c54
Update opinionated protocol tests to not describe optional behavior
jasdel Jul 2, 2020
7ff4c45
add test for empty json object deserialize
jasdel Jul 2, 2020
b8a4ffe
fixup unique test case name
jasdel Jul 2, 2020
254f730
fixup PR feedback
jasdel Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion smithy-aws-protocol-tests/model/restJson1/empty-input-output.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ apply EmptyInputAndEmptyOutput @httpRequestTests([
protocol: restJson1,
method: "POST",
uri: "/EmptyInputAndEmptyOutput",
body: "{}",
body: "",
jasdel marked this conversation as resolved.
Show resolved Hide resolved
bodyMediaType: "application/json"
},
])
Expand All @@ -97,6 +97,14 @@ apply EmptyInputAndEmptyOutput @httpResponseTests([
body: "",
bodyMediaType: "application/json"
},
{
id: "RestJsonEmptyInputAndEmptyJsonObjectOutput",
documentation: "Empty output serializes no payload",
protocol: restJson1,
code: 200,
body: "{}",
bodyMediaType: "application/json"
},
])

structure EmptyInputAndEmptyOutputInput {}
Expand Down
14 changes: 0 additions & 14 deletions smithy-aws-protocol-tests/model/restJson1/http-prefix-headers.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,6 @@ apply HttpPrefixHeaders @httpResponseTests([
}
}
},
{
id: "RestJsonHttpPrefixHeadersAreNotPresent",
documentation: "No prefix headers are serialized because the value is empty",
protocol: restJson1,
code: 200,
body: "",
headers: {
"X-Foo": "Foo"
},
params: {
foo: "Foo",
fooMap: {}
}
},
])

structure HttpPrefixHeadersInputOutput {
Expand Down