Skip to content

Commit

Permalink
Merge pull request godotengine#96934 from smix8/planemesh_gizmo
Browse files Browse the repository at this point in the history
Fix `MeshInstance3D` gizmo redraw performance for `PlaneMesh` with larger subdiv value
  • Loading branch information
akien-mga committed Sep 13, 2024
2 parents 84f1fe7 + b8de7b7 commit d5d6c73
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion editor/plugins/gizmos/mesh_instance_3d_gizmo_plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "editor/plugins/node_3d_editor_plugin.h"
#include "scene/3d/mesh_instance_3d.h"
#include "scene/3d/soft_body_3d.h"
#include "scene/resources/3d/primitive_meshes.h"

MeshInstance3DGizmoPlugin::MeshInstance3DGizmoPlugin() {
}
Expand Down Expand Up @@ -64,7 +65,22 @@ void MeshInstance3DGizmoPlugin::redraw(EditorNode3DGizmo *p_gizmo) {
return; //none
}

Ref<TriangleMesh> tm = m->generate_triangle_mesh();
Ref<TriangleMesh> tm;

Ref<PlaneMesh> plane_mesh = mesh->get_mesh();
if (plane_mesh.is_valid() && (plane_mesh->get_subdivide_depth() > 0 || plane_mesh->get_subdivide_width() > 0)) {
// PlaneMesh subdiv makes gizmo redraw very slow due to TriangleMesh BVH calculation for every face.
// For gizmo collision this is very much unnecessary since a PlaneMesh is always flat, 2 faces is enough.
Ref<PlaneMesh> simple_plane_mesh;
simple_plane_mesh.instantiate();
simple_plane_mesh->set_orientation(plane_mesh->get_orientation());
simple_plane_mesh->set_size(plane_mesh->get_size());
simple_plane_mesh->set_center_offset(plane_mesh->get_center_offset());
tm = simple_plane_mesh->generate_triangle_mesh();
} else {
tm = m->generate_triangle_mesh();
}

if (tm.is_valid()) {
p_gizmo->add_collision_triangles(tm);
}
Expand Down

0 comments on commit d5d6c73

Please sign in to comment.