Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Generation 7 modifier order per OZY's research #331

Closed
scheibo opened this issue Aug 4, 2019 · 1 comment
Closed

Correct Generation 7 modifier order per OZY's research #331

scheibo opened this issue Aug 4, 2019 · 1 comment

Comments

@scheibo
Copy link
Contributor

scheibo commented Aug 4, 2019

From a cursory glance, the conditions for checking if a modifier should be applied is correct; it's moreso the order. The listed modifiers (BP, Attack, Defense, final modifiers, general damage modifiers), are taken from OZY's research, which is considered to be the authoritative research for Gen 7 and is what the simulator itself is using (or minimally should be using).

Originally posted by @DaWoblefet on Smogon

This may require copying calc/src/mechanics/gen7.ts to calc/src/mechanics/gen6.ts and redoing gen7.ts with the new changes, though a way which shares more code would probably be worth investigation.

@scheibo
Copy link
Contributor Author

scheibo commented Aug 11, 2019

scheibo added a commit that referenced this issue Apr 8, 2020
Thanks Austin (@AustinXII) and Anubis (@Lusamine) for their help verifying this.
@scheibo scheibo closed this as completed in a056d40 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant