Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Move Max Move Type #437

Open
jbmagier opened this issue Mar 29, 2021 · 2 comments
Open

Dynamic Move Max Move Type #437

jbmagier opened this issue Mar 29, 2021 · 2 comments

Comments

@jbmagier
Copy link
Contributor

The moves with dynamic types - Weather Ball, Terrain Pulse, and Nature Power - all fail to become their respective Max Move counterparts and instead become Max Strike. Weather Ball's presence in VGC is more prominent than ever, so fixing this is pretty important.

This will likely require a Field being passed through getMoveDetails to move.ts
jbmagier added a commit to jbmagier/damage-calc that referenced this issue Mar 29, 2021
@jbmagier
Dynamic Max Moves get the right type, name and desc still wrong (smog…
01d9656 
…on#437)
KrisXV pushed a commit that referenced this issue Apr 27, 2021
@jbmagier
Added Power Spot, Fixed Dauntless Shield, Made Competitive activate f…
8d527cb 
…rom Intimidate, Cleaned up EV and IV exporting (#435)

* Added Power Spot

* Fixed a minor typo

* fixed Dauntless Shield Bug (#436)

* added a trigger for Competitive when opposing Pokemon has Intimidate

* cleaned up IV and EV exporting

* added iron ball check to immunity checks

* added iron ball check to immunity checks, made terrain pulse only take terrain type for grounded pokemon

* made max move names change based on ability

* added Iron Ball to isGrounded check

* Dynamic Max Moves get the right type, name and desc still wrong (#437)
@InvalidOS
Copy link

This also affects their Z-Move counterparts; both Weather Ball and Terrain Pulse get turned into Breakneck Blitz regardless of weather or terrain, and Nature Power is not changed at all.

Also, this affects all other moves with dynamic types, including Revelation Dance, Tera Blast (this one isn't really too relevant outside of maybe some fangame I don't know about), Aura Wheel, etc.

-ate abilities seem to behave fine, at least with Dynamax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbmagier @InvalidOS and others