/suspects: Rename setcoil
#10667
Merged
/suspects: Rename setcoil
#10667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisXV
commented
Nov 9, 2024
| let bVal: number | undefined = parseFloat(source); | ||
| if (cmd.startsWith('d')) { | ||
| bVal = undefined; | ||
| } else if (!source || isNaN(bVal) || bVal < 1) { | ||
| return this.errorReply(`Specify a valid COIL B value.`); | ||
| } | ||
| if (!formatid || !Dex.formats.get(formatid).exists) { | ||
| if (!toID(formatStr) || !format.exists) { |
There was a problem hiding this comment.
Technically the first check for the formatStr argument isn't required since Dex.formats.get sanitizes the string even if no format exists, but I left this in regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setbvaluemakes more sense thansetcoilsince the property being adjusted is the b value, and the COIL threshold is set separately in/suspects add(perhaps support can also be added to the latter command to require the b value as an argument if coil is specified?). I also calledDex.formats.getearlier on in the command because the formatting of using a format's name is more fitting with the rest of the design of/suspects.