Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+CMD+R, Shift+CMD+G interfere with IDE keybinds, make keybinds customizable #84

Closed
0xAsynchronous opened this issue Jul 23, 2023 · 5 comments · Fixed by #85
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@0xAsynchronous
Copy link

The current keybinds, specifically Shift+CMD+R and Shift+CMD+G, are interfering with keybinds in my IDE. This is causing unexpected behavior and disrupting my workflow. Ideally, the keybinds should be customizable, allowing users to avoid conflicts with other software, via a settings page or at least a config file.

@swyxio
Copy link
Contributor

swyxio commented Jul 24, 2023

agree! happy to take a PR, i dont really know how to do this yet

@swyxio swyxio added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 24, 2023
@swyxio
Copy link
Contributor

swyxio commented Jul 24, 2023

another approach could be to offer a few variants of activation keys other than CMD+Shift

@davej
Copy link
Contributor

davej commented Jul 24, 2023

@swyxio I could take this on by adding a simple settings window. Not sure how to do this without a settings window. Would you be ok with me adding Svelte + Vite as build-time dependencies?

@yazinsai
Copy link

+1, also Cmd + Shift + F which is "search across all files" in VS Code. It's so pervasive I think it might make sense to not have it be the default shortcut.

swyxio added a commit that referenced this issue Jul 27, 2023
@swyxio
Copy link
Contributor

swyxio commented Jul 27, 2023

@yazinsai i hear you, @seanoliver added that one, Sean could you please propose a different shortcut? or we can drop it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants