Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIRI to CI #85

Open
notgull opened this issue Apr 8, 2024 · 1 comment
Open

Add MIRI to CI #85

notgull opened this issue Apr 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@notgull
Copy link
Member

notgull commented Apr 8, 2024

We should add MIRI tests to the CI here. It looks like some of the tests are broken under CI at the moment. See here.

cc @taiki-e When you originally set up the CI for this crate, did you intentionally avoid MIRI here for this reason?
@notgull notgull added the bug Something isn't working label Apr 8, 2024
notgull added a commit to smol-rs/async-lock that referenced this issue Apr 8, 2024
@notgull
tests: Replace async-channel with flume
7fb3b9b 
This commit replaces async-channel in some tests with flume. It appears
that async-channel doesn't work under MIRI but flume does, so we can
work around this for now by replacing it with flume.

cc smol-rs/async-channel#85

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull mentioned this issue Apr 8, 2024
Merged
notgull added a commit to smol-rs/async-lock that referenced this issue Apr 8, 2024
@notgull
Replace async-channel with flume
5428311 
This commit replaces async-channel in some tests with flume. It appears
that async-channel doesn't work under MIRI but flume does, so we can
work around this for now by replacing it with flume.

cc smol-rs/async-channel#85

Signed-off-by: John Nunley <dev@notgull.net>
@taiki-e
Copy link
Collaborator

taiki-e commented Apr 9, 2024

I'm not the person who originally set up the CI for this crate...

See here.

It shows as "cancelled", is it an automatic cancellation or a manual cancellation by you?

If you have not made any changes to the test files, it is not surprising that the test of this crate takes a long time to run, since the iterations are too many to run in Miri. In that case, you can reduce the number of iterations as I did with crossbeam and concurrent-queue tests (e.g., smol-rs/concurrent-queue@434e8e9).

If you still have problems, I have not seen similar problems with crossbeam-channel, so I'm considering the possibility that the problem is something that is not used in crossbeam-channel, such as event-listener. You may want to see if versions that use older event-listener have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notgull @taiki-e