Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually implement Clone on WeakSender/Receiver #62

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Manually implement Clone on WeakSender/Receiver #62

merged 1 commit into from
Jul 5, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 5, 2023

Right now, WeakSender<T> and WeakReceiver<T> implement Clone only if T implements Clone as well.

It seems to me that this is an overlook and isn't actually intended.

notgull
notgull approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 49216cd into smol-rs:master Jul 5, 2023
@tomaka tomaka deleted the clone-no-auto branch July 5, 2023 13:14
@notgull notgull mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @notgull