Fix a bug where TLS would become None #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug is invoked as follows: - Runner 1 is created and stores the current version of the TLS LOCAL_QUEUE variable, which is None. - Runner 2 is also created. It stores the current version of the TLS variable as well, which is Runner 1's queue. - Runner 1 is dropped. It stores None into the LOCAL_QUEUE variable. - Runner 2 tries to run. It reads from the LOCAL_QUEUE variable, sees that it is None, and panics. This could be solved by just not using the local queue if the variable is None. However, we can do one better; if the slot is open, we can optimize the runner by replacing it with our own queue. This should allow for the local queue to be used more often. Closes #54 Signed-off-by: John Nunley <dev@notgull.net>
notgull
commented
Sep 27, 2023
Signed-off-by: John Nunley <dev@notgull.net>
taiki-e
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is invoked as follows:
This could be solved by just not using the local queue if the variable is None. However, we can do one better; if the slot is open, we can optimize the runner by replacing it with our own queue. This should allow for the local queue to be used more often.
Closes #54