Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 2.7.0 #38

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Release version 2.7.0 #38

merged 1 commit into from
Feb 26, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Feb 25, 2023

@notgull
Copy link
Member Author

notgull commented Feb 25, 2023

Whoops, realized that #34 is not a patching change. Let me fix that.

@notgull notgull changed the title Release version 2.6.1 Release version 2.7.0 Feb 25, 2023
@notgull notgull merged commit e525424 into master Feb 26, 2023
@notgull notgull deleted the notgull/next branch February 26, 2023 15:06
@notgull
Copy link
Member Author

notgull commented Feb 26, 2023

Hmm, does squash merging break the auto-releaser? I guess I have to push again

@taiki-e
Copy link
Collaborator

taiki-e commented Feb 27, 2023

auto-releaser

It rejects tags not available in master.

@taiki-e
Copy link
Collaborator

taiki-e commented Feb 27, 2023

Hmm. I noticed Cargo.toml's release guide is from when we were pushing release commits without going through PR. It needs to be updated. The latest version is something like:

  • Update version and CHANGELOG.md
  • Create PR including the above change
  • (once the PR is merged) Create "v2.x.y" git tag on the merged commit and push it (git push origin --tags)
  • Run cargo +stable publish (do not use nightly because it is sometimes broken)

@notgull
Copy link
Member Author

notgull commented Mar 2, 2023

Weird; it looks like the merge commit was tagged with 2.7.0. Not sure why that didn't go through?

Anyways, I manually created the release on GitHub and published the new version to crates.io.

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 2, 2023

v2.7.0 tag points to 89f94e7, but it is not included in the master branch.

https://github.com/smol-rs/async-lock/actions/runs/4316235059/jobs/7531735651

rel

The correct commit is e525424 at the head of the current master branch.

@notgull
Copy link
Member Author

notgull commented Mar 2, 2023

Thanks for the explanation @taiki-e! I'll keep this in mind for future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants