Add reference-counted versions of RwLock guards
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jules-Bertholet
force-pushed
the
arc-rwlock-guards
branch
from
e132c66
to
c95ea6c
Compare
notgull
requested changes
Jun 1, 2023
There was a problem hiding this comment.
The rwlock.rs file is getting to be a bit long; I think it should be split into multiple files. As a rule of thumb, a single module shouldn't be more than 1000 lines.
(I'm busy for the time being and won't be able to take a more in depth look until the weekend).
Jules-Bertholet
force-pushed
the
arc-rwlock-guards
branch
from
c95ea6c
to
d7989f8
Compare
notgull
reviewed
Jun 3, 2023
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| fmt::Debug::fmt(&**self, f) | ||
| } | ||
| } | ||
|
|
||
| impl<T: fmt::Display + ?Sized> fmt::Display for RwLockUpgradableReadGuard<'_, T> { | ||
| #[inline] |
There was a problem hiding this comment.
Is there any reason why you've inlined several methods here?
There was a problem hiding this comment.
Consistency with the equivalent trivial methods on the Arc guards. I can remove them if you like
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33