Use the waiter backend on Windows #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
force-pushed
the
notgull/wait-windows
branch
2 times, most recently
from
99664ea to
adfb279
Compare
In async-process, we have a backend that assumes that child processes are object that can be `.await`ed on, rather than just being dependent on signals. At the moment it is only used with Linux and pidfd. Now, it is used with Windows and the waitable process backend. At the moment, the backend for `Waitable` in `async-io` is just backed by a blocking threadpool. However it may also be possible to have it use IOCP too with little extra overhead. See smol-rs/polling#141 for more information. As a side effect, this removes our dependency on `windows-sys`. Signed-off-by: John Nunley <dev@notgull.net>
notgull
force-pushed
the
notgull/wait-windows
branch
from
adfb279 to
4154e03
Compare
fogti
requested changes
Aug 12, 2024
|
what's the overall advantage/benefit of this? |
Better scalability. Now we don't wake every subprocess task in the program whenever one single subprocess finishes. |
Signed-off-by: John Nunley <dev@notgull.net>
fogti
approved these changes
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In async-process, we have a backend that assumes that child processes
are object that can be
.awaited on, rather than just being dependenton signals. At the moment it is only used with Linux and pidfd. Now, it
is used with Windows and the waitable process backend.
At the moment, the backend for
Waitableinasync-iois just backedby a blocking threadpool. However it may also be possible to have it use
IOCP too with little extra overhead. See smol-rs/polling#141 for more
information.
As a side effect, this removes our dependency on
windows-sys.