Skip to content

Commit

Permalink
Remove the signalfd backend
Browse files Browse the repository at this point in the history
This backend appears to miss some signals that are raised on other
threads. This might be the cause of smol-rs/async-process#55.

I don't feel like kneading signalfd into a better shape, and it probably
isn't much of an improvement over the pipe strategy anyways. So I've just
removed it.

Signed-off-by: John Nunley <dev@notgull.net>
  • Loading branch information
notgull committed Sep 30, 2023
1 parent 1d9a51d commit a59beb6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 217 deletions.
3 changes: 0 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ features = [
"Win32_System_Console",
]

[target.'cfg(any(target_os = "android", target_os = "linux"))'.dependencies]
concurrent-queue = "2.2.0"

[dev-dependencies]
async-io = "1.12.0"
fastrand = "2.0.1"
Expand Down
8 changes: 1 addition & 7 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,7 @@
)]

cfg_if::cfg_if! {
if #[cfg(async_signal_force_pipe_impl)] {
mod pipe;
use pipe as sys;
} else if #[cfg(any(target_os = "android", target_os = "linux"))] {
mod signalfd;
use signalfd as sys;
} else if #[cfg(windows)] {
if #[cfg(windows)] {
mod channel;
use channel as sys;
} else {
Expand Down
207 changes: 0 additions & 207 deletions src/signalfd.rs

This file was deleted.

0 comments on commit a59beb6

Please sign in to comment.