feat: Add functionality for posting events to the IOCP #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogti
reviewed
Apr 8, 2023
|
ok idk I probably can't accurately test this; I have no direct access to any windows machine, and even if I could I currently don't have time to bother to freshly setup rust and get stuff to work there... code-wise, I count this as "should be good enough". LGTM. might just lack in testing. |
|
I added some tests to make sure it all works. |
fogti
reviewed
Apr 14, 2023
| .post(CompletionPacket::new(Event::writable(i))) | ||
| .unwrap(); | ||
|
|
||
| thread::sleep(Duration::from_millis(100)); |
There was a problem hiding this comment.
the timing of stuff here looks odd...
There was a problem hiding this comment.
I did this to make sure that, even if the main thread handles the first packet, it will fall asleep before handling the second one. This way we can be sure that a completion packet wakes up the thread.
fogti
approved these changes
Apr 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
CompletionPacketstructure that can be used to post arbitrary events to the I/O completion port. The idea is to allow for self-wakeups without using pipes, which aren't available on Windows.