Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce Event::new() #149

Merged
merged 1 commit into from
Sep 12, 2023
Merged

introduce Event::new() #149

merged 1 commit into from
Sep 12, 2023

Conversation

dimbleby
Copy link
Contributor

fixes #148

@dimbleby dimbleby mentioned this pull request Sep 11, 2023
Closed
notgull
notgull requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make all of the functions that just wrap around new() #[inline]?

@dimbleby
Copy link
Contributor Author

Could you make all of the functions that just wrap around new() #[inline]?

done

notgull
notgull approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 254577d into smol-rs:master Sep 12, 2023
@dimbleby dimbleby deleted the event-construction branch September 12, 2023 13:15
@notgull notgull mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

awkward to construct Event in 3.0.0
2 participants
@dimbleby @notgull